Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make better print styles for PDFs exporting #300

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Make better print styles for PDFs exporting #300

merged 1 commit into from
Jan 20, 2025

Conversation

alashchev17
Copy link
Collaborator

Make better print styles for PDFs exporting

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, only code improvements)
  • Documentation update

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have updated the documentation where necessary.

@alashchev17 alashchev17 self-assigned this Jan 20, 2025
MarcMcIntosh
MarcMcIntosh approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@MarcMcIntosh MarcMcIntosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know it was printable, will IDE's be able to do this?

@alashchev17 alashchev17 merged commit bed8c08 into alpha Jan 20, 2025
2 checks passed
@alashchev17 alashchev17 deleted the chore/make-better-print-styles-for-pdfs branch January 20, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcMcIntosh MarcMcIntosh MarcMcIntosh approved these changes

@kinokritik kinokritik Awaiting requested review from kinokritik

Assignees

@alashchev17 alashchev17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alashchev17 @MarcMcIntosh