WIP: api_key cookies #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, the react-cookie library doesn't have the best type definitions so that explains where a few of the eslint errors came from, I've replaced it with js-cookie which which is client side only but does what needs to be done. From a design/ux perspective, I think we'll make the input area modal that can opened either when a failed request is sent or when the user clicks on a settings button. For the settings button I think an icon in the footer of the side bar would make most sense :) |
MarcMcIntosh
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit is WIP and you can check it with https://github.com/smallcloudai/refact/tree/access-fixes branch