User find #31
Merged
User find #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user id instead of username
…ofile, parse signature user find
…e, update proxy pagination to support next/prev
…ser profile in front end
…is only one record
…if user doesnt want to be shown as active within the past 72 hours
lib/epochtalk_server/bbc_parser.ex
Outdated
| use GenServer | ||
| require Logger | ||
| alias Porcelain.Process, as: Proc | ||
| @timeout 10_000 |
There was a problem hiding this comment.
timeout's unreasonably long. should reduce it to a realistic amount
long timeout will hang and back up the queue if there is an issue
There was a problem hiding this comment.
an example is when empty string is given as input
config/runtime.exs
Outdated
| @@ -407,6 +407,16 @@ end | |||
|
|
|||
| ##### PROXY REPO CONFIGURATIONS ##### | |||
|
|
|||
| poolboy_config = [ | |||
There was a problem hiding this comment.
we can rename this to bbc_parser_config
it's the poolboy config for a specific part of the code;
in the case we add another poolboy managed process, we'll need the extra namespace
lib/epochtalk_server/application.ex
Outdated
| @@ -21,6 +21,8 @@ defmodule EpochtalkServer.Application do | |||
| EpochtalkServer.Repo, | |||
| # Start the Smf repository | |||
| EpochtalkServer.SmfRepo, | |||
| # Start the BBC Parser | |||
| :poolboy.child_spec(:bbc_parser, poolboy_config()), | |||
There was a problem hiding this comment.
when we call child_spec here, poolboy_config() call can be changed to a call to bbc_parse_config()
| @@ -15,6 +15,10 @@ function setReasonableValues() | |||
| $context['browser']['is_ie5'] = false; | |||
| $context['browser']['is_ie5.5'] = false; | |||
|
|
|||
| // Fix for portuguese characters (test: http://localhost:8000/threads/5515847) | |||
| $context['utf8'] = true; | |||
| $context['server']['complex_preg_chars'] = true; | |||
specifically, the poolboy_config for bbc_parser
10 seconds is much too long, we don't want to take up resources for that amount of time. 1 second is fairly long as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poorly named branch, sorry.
This adds: