-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Project Gen to Skate #744
Conversation
Re: the remaining work I think we should actually try using the jetbrains/jewel compose theme instead to make this look native in the IDE rather than material. No need to add custom fonts or bring our own icon. Can be a follow up though! Another thought: can we change the done dialog and do something like a "Close and sync" + "Close", with the former being the primary? |
@@ -24,6 +24,7 @@ plugins { | |||
alias(libs.plugins.intellij) | |||
alias(libs.plugins.pluginUploader) | |||
alias(libs.plugins.buildConfig) | |||
alias(libs.plugins.compose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may also need the kotlin.multiplatform plugin here in place of kotlin.jvm but not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking since Skate is Intellij plugin, having kotlin.jvm should be enough. Does having kotlin.multiplatform mean we'll extend to other platforms like iOS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily, it just sets up the KMP structure. If you look at the build file in the original repo, it does the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see. I can try moving the KMP structure over
@@ -0,0 +1,153 @@ | |||
/* | |||
* Copyright (C) 2022 Slack Technologies, LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Copyright (C) 2022 Slack Technologies, LLC | |
* Copyright (C) 2024 Slack Technologies, LLC |
Can you fix up the other new files too before you merge?
This PR moves Project Gen Compose app to Skate so it can be called directly from the IDE. I made some modifications, including:
ProjectGenWindow
that extendsDialogWrapper
to wrap around the Compose appprojectgenlock
on the fly and delete it when dialog is dismissedDarkMode
status from the IDE Theme usingJBColors.isBright
Quit
button to exit the dialog. It was exiting the application beforeTerminalWrapper
codeRemaining work I haven't been able to port over. Running into some issues that might take more time
Font
toLato
Test:
Light mode
light_mode_project_gen.mov
Dark mode
project_gen.mov