Add tracing to model translator generation #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saifc
commented
Nov 15, 2023
| @@ -34,14 +39,35 @@ class GenerateTranslatorBodyAction(private val bundle: TranslatorBundle) : Inten | |||
| override fun startInWriteAction() = true | |||
|
|
|||
| override fun invoke(project: Project, editor: Editor?, psiFile: PsiFile?) { | |||
| val startTimestamp = Instant.now() | |||
There was a problem hiding this comment.
Starting measurement here to know how long it takes for the generation to happen.
I noticed that in other parts of the plugin, this is created as a field with the action creation as part of the annotation process, is that on purpose for some reason?
There was a problem hiding this comment.
It's intentional for the WhatsNewPanelListener because I want to measure the session time when the window was initially hidden (the listener is created) and then opened.
For the other parts, I should change them similarly to this PR :). I wasn't particularly interested in tracking the duration for ProjectGen & FeatureFlag Annotation then.
linhpha
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the other parts of the plugin by adding tracing to the model translator generation.