fix: inline anonymous class wrongly handles field as Classname.this #2367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If option "inline anonymous class" is checked, sometimes the field of the anonymous class is wrongly recoginized as the instance of its parent class, which actually is instance of a random class. This leads to the field being added
CLASS_INSTANCE
typeFieldReplaceAttr
and displayed asFieldClassName.this
rather than its normal name.example dex
decompiled code: notice that
another
is displayed asAnotherClass.this
this pr extracts
Objects.equals(parentClass, fieldsCls.getClassInfo())
, and only add CLASS_INSTANCE replace attr if it is true.