Kotlin toString renamer produces illegal filenames and may override files during export #2041
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
This PR fixes this issue with a check for valid identifiers before rename. An working alternate fix would be using BetterName, since it includes the valid identifier check, but I wasn't sure if the BetterName metric for java is the same as for kotlin. If you prefer BetterName, please reject my PR and I'll fix this with BetterName.
This PR will fix lots of syntax errors in exported sources.
With other apps I've also seen class names like "." generating a filename "..java", but I haven't found any apps with path traversal attacks yet.