Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve route logic in visor side #1921

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Jan 21, 2025

Did you run make format && make check? Yes

Fixes #_

Changes:

  • change default (and hardcoded) value of max_hop from 50 to 1000. (not included on visor config)
  • change default value of min_hop in config from 0 to 1. 0 was meaningless.
  • add retrier on trying find route by skysocks-client
  • fix data race found in skysocks-client (Data race in sky socks-client #1923)

How to test this PR:

  • for check change minhop value in config, generate a config
  • for retry function, run visor, start skysock-client with dummy but correct PK as skysocks server PK, check logs

@mrpalide mrpalide changed the title [WIP] Improve route logic in visor side Improve route logic in visor side Jan 23, 2025
@mrpalide mrpalide marked this pull request as ready for review January 23, 2025 16:06
@0pcom 0pcom self-requested a review January 23, 2025 16:50
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mrpalide mrpalide merged commit 7e314a7 into skycoin:develop Jan 26, 2025
3 checks passed
@mrpalide mrpalide deleted the fix/improve-rf-logic-in-visor-side-based-on-new-changes-on-rf-algorithm branch January 26, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants