Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codebase issues #1885

Merged

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Oct 15, 2024

Did you run make format && make check? Yes

Fixes #_

Changes:

  • upgrade golang to v1.23
  • fix golangci-lint issues

How to test this PR:
TBD

@0pcom
Copy link
Collaborator

0pcom commented Oct 17, 2024

Should we really update golang to a version that doesn't exist yet?

I'm sure you meant v1.23 ;)

On a similar note, should make sure to update golangci-lint to the latest version if it's not at that already.

When that is updated, the one type of error that I haven't figured out how to resolve to the liking of golangci-lint is type conversion for int64 to int and similarly with uint. other than commenting //nolint

if a proper solution to that can be found, it would be good to post it here for future reference

@mrpalide
Copy link
Contributor Author

Yes, I see your changes after create my PR, lol :))

We should do more investigation on that convert types and probability issues, and handle them.

But, for now, I merge this PR, because of some little changes. lol :))

@mrpalide mrpalide merged commit 59a24a4 into skycoin:develop Oct 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants