Add CSRF protection to the Hypervisor API #1604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
How to test this PR:
Try to make a POST, PUT or DELETE operation using the hypervisor API, it will return an error. For getting the token, you must first call the
GET /csrf
API endpoint.The CSRF token should be added to the
X-CSRF-Token
header of the API requests, for the server to check it. The token is valid for 30 seconds only.If you recompile the UI and make the operations with it, it will get and use the token automatically, so everything should work normally.
NOTE: Maybe a config option should be added to disable the CSRF token protection.