Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cobra command to initiate order timeout #78

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

nadim-az
Copy link
Contributor

No description provided.

@nadim-az nadim-az requested a review from a team as a code owner November 26, 2024 22:47
Copy link
Contributor

@dhfang dhfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the db dependency here? This requires the db to be prepopulated by the solver to be used, whereas it would be nice if customer support could use this command on their local machines

Copy link
Contributor

@dhfang dhfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note this also does not relay the timeout to the destination. have you tested this end to end?

let's just make a note in the readme for both the initiate timeout and settlement commands that hyperlane message must be relayed separately and include instructions for how to use the relay command

cmd/solvercli/cmd/initiate_timeout.go Show resolved Hide resolved
cmd/solvercli/cmd/initiate_timeout.go Show resolved Hide resolved
@nadim-az nadim-az force-pushed the na/add-timeout-cli branch from 34634e2 to 4c616c2 Compare January 7, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants