feat(digitalocean): get user IP over v4/v6 #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivasan1
requested review from
Zygimantass,
davidterpay,
aljo242 and
Eric-Warehime
as code owners
Zygimantass
approved these changes
Mar 18, 2024
| if err != nil { | ||
| return ips, err | ||
| if len(ips) == 0 { | ||
| err = fmt.Errorf("failed to get user IP: %v", errs) |
There was a problem hiding this comment.
looks loike this never gets returned?
| @@ -41,41 +43,71 @@ func makeSSHKeyPair() (string, string, string, error) { | |||
| } | |||
|
|
|||
| func getUserIPs(ctx context.Context) (ips []string, err error) { | |||
| res, err := http.Get("https://ifconfig.io") | |||
There was a problem hiding this comment.
ideally here, we try both ifconfig.io and ifconfig.co (different ASNs, so they'll get routed through different paths) and try both IPv4 and IPv6. we should also add the option in the provider to append a custom IP
|
closing, we should just make the user provide an IP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.