Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(digitalocean): make task + sidecar startup concurrent #122

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

nivasan1
Copy link
Contributor

No description provided.

Copy link
Contributor

@Zygimantass Zygimantass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one comment

@@ -70,6 +70,8 @@ func NewDigitalOceanProvider(ctx context.Context, logger *zap.Logger, providerNa
sshFingerprint: sshFingerprint,
}

logger.Info("petri tag", zap.String("tag", digitalOceanProvider.petriTag))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably remove this or move to debug

@Eric-Warehime Eric-Warehime merged commit a9f9908 into nv/caching-ssh-client Nov 5, 2024
3 checks passed
@Eric-Warehime Eric-Warehime deleted the nv/concurrent-task-creation branch November 5, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants