NEXT: Skeleton v3 Migration CLI #2972
Conversation
🦋 Changeset detectedLatest commit: d4bfcb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Hugos68 is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
@Hugos68 everything is looking great. Just a few bits of feedback so far.
packages/cli/src/commands/migrate/migrations/skeleton-3.test.ts
Outdated
Show resolved
Hide resolved
|
|
||
| const TAILWIND_COMPONENT_REGEXES = [ | ||
| { | ||
| find: /\bcard\b(?!.*bg-)/g, |
There was a problem hiding this comment.
Just as a heads up - we need to ensure we don't just blindly insert the background class for .card migrations. It should only be added if no existing bg- class is found in the class list.
Imagine a scenario like this in a v2 project:
<div class="card bg-primary-400-500">...</div>The card already has a background established, but the migration would insert our additional (and undesired) background class:
<div class="card bg-surface-100-900-token bg-primary-500 dark:bg-primary-500">...</div>In this case, no migration should have occurred for this instance.
There was a problem hiding this comment.
We can't migrate that then, there is no way to detect wether bg- is present or not as it can be added in a million ways.
For example class="card {bgClasses}", I'd say we skip this and/or migrate the card class without a background by default.
There was a problem hiding this comment.
Potential solution from Discord. Append folk's global stylesheet and add the following:
/* SKETON CLI - appended this to ensure backwards combability. Please remove and update your `.card` usage. */
.card { @apply bg-surface-100-900; }
Just FYI, a gotcha with the global stylesheet is the extension varies in my experience. I've seen several options:
app.postcssapp.pcssapp.css
|
@Hugos68 I'm going to be going through and update all project dependencies for the Skeleton monorepo per: Can you please make sure the migration CLI is updated to support Node 22 - assuming it's not already! Otherwise disregard this message. |
Linked Issue
No issue (perhaps we should create one)
Description
Introduces the official Skeleton CLI that currently features:
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages, runpnpm changesetin the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminorwhile chores and bugfixes should bepatch. Please prefix the changeset message withfeat:,bugfix:orchore:.Checklist
Please read and apply all contribution requirements.
devbranch (NEVERmaster)docs/,feat/,chore/,bugfix/pnpm ci:checkpnpm formatpnpm test