Skip to content

Commit

Permalink
Remove exception notifications over email
Browse files Browse the repository at this point in the history
Since these sites are no longer in active development and are fairly
stable, these notifications are more noise than anything useful.
Exceptions usually occur while folks attempt to exploit the site with
sending broken/erroneous payloads, which is not particularly
interesting.

Exceptions will continue to be logged to the production.log file and can
be examined on demand.

Should this functionality be needed, it must be introduced
conditionally, configured in the per-course-edition files.
  • Loading branch information
mitio committed Oct 21, 2022
1 parent ff07ccf commit a77ee05
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
4 changes: 0 additions & 4 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ gem 'sinatra', require: false
# See https://stackoverflow.com/a/60491254/75715
gem 'bigdecimal', '1.3.5'

group :production do
gem 'exception_notification'
end

group :assets do
gem 'sass-rails', '~> 4.0'
gem 'sass', '~> 3.2.0'
Expand Down
4 changes: 0 additions & 4 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,6 @@ GEM
mail (~> 2.2)
erubis (2.7.0)
eventmachine (1.0.8)
exception_notification (4.1.1)
actionmailer (>= 3.0.4)
activesupport (>= 3.0.4)
execjs (2.7.0)
factory_girl (4.5.0)
activesupport (>= 3.0.0)
Expand Down Expand Up @@ -389,7 +386,6 @@ DEPENDENCIES
diff-lcs
draper
email_spec
exception_notification
factory_girl_rails
faker
guard
Expand Down
6 changes: 0 additions & 6 deletions config/environments/production.rb
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,6 @@
config.action_mailer.smtp_settings = config.smtp_settings.symbolize_keys
config.action_mailer.default_url_options = {host: config.course_domain}

config.middleware.use ExceptionNotification::Rack, email: {
email_prefix: '[ERROR] ',
sender_address: "Exception Notifier <#{config.course_email}>",
exception_recipients: [config.course_email]
}

# Eager load
config.eager_load = true
end

0 comments on commit a77ee05

Please sign in to comment.