Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schain allocation type to SchainOptions #561

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Conversation

badrogger
Copy link
Collaborator

@badrogger badrogger commented Aug 19, 2024

Changes:

  • Add allocation type to SchainOptions.

Performance

  • No performance related changes were introduced.

Testing

  • Added additional unit tests.

@badrogger badrogger changed the title Schain allocation type Add schain allocation type to SchainOptions Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.14%. Comparing base (5762912) to head (2e2f8e1).
Report is 4 commits behind head on beta.

Files Patch % Lines
skale/dataclasses/schain_options.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #561      +/-   ##
==========================================
- Coverage   91.16%   91.14%   -0.02%     
==========================================
  Files          65       65              
  Lines        2468     2474       +6     
==========================================
+ Hits         2250     2255       +5     
- Misses        218      219       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger merged commit 2531b0f into beta Aug 19, 2024
8 checks passed
@badrogger badrogger deleted the schain-allocation-type branch August 19, 2024 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants