Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web3 version, add change ip ts func #549

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

dmytrotkk
Copy link
Collaborator

This PR updates web3py and sgx.py versions to the latest available.
Also this PR adds a function to get last ip change timestamp and test for it.

Added unit test for the new function.
No performance changes.

Resolves skalenetwork/skale-admin#832

@dmytrotkk dmytrotkk self-assigned this Jan 3, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6211cb6) 90.87% compared to head (60fa8b7) 91.16%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #549      +/-   ##
===========================================
+ Coverage    90.87%   91.16%   +0.29%     
===========================================
  Files           65       65              
  Lines         2466     2468       +2     
===========================================
+ Hits          2241     2250       +9     
+ Misses         225      218       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger merged commit e4c7806 into develop Jan 4, 2024
8 checks passed
@badrogger badrogger deleted the feature/add-change-ip-ts-func branch January 4, 2024 15:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a procedure to update sChain configs when IP is changed on one of the nodes
2 participants