Add ability to provide a custom IP checker URL. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pgreenland! Thanks for your contribution! Will review over the next few weeks and get it merged. |
|
Hi @pgreenland thanks for your contribution! I got really busy around the holiday and started a new job in the new year. Will get this merged shortly. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After being hit by the recent opendns issues, I thought I might switch to a private IP source, such as my home router.
Rather than just hack in my new URL I thought it might be useful for others to add the ability for a custom URL to be provided.
This patch adds a new IPCHECKER "custom" with an associated parameter IPCHECKER_CUSTOM_URL, specifying the URL to request the external IP from.
I've added HTTP support too, selected based on the URI scheme, with a warning generated if HTTP is used.
Documentation updated (along with a few typos), container built and published to my dockerhub account (pgreenland/route53-dynamic-dns:latest), have tested with the default and my custom handler.
FYI I'm not normally a node.js / javascript developer, so I may have done something monumentally stupid somewhere. Happy for you to suggest or make any changes required to include it.
Great project btw, saved me a ton of work!
Thanks,
Phil