Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/six sidebar expose container part #263

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

flamenkito
Copy link
Collaborator

@flamenkito flamenkito commented Jun 17, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Expose container part in six-sidebar for styling.
Get rid of width parameter in favor of --width CSS variable.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@flamenkito flamenkito requested a review from davidemarcoli June 17, 2024 12:58
@flamenkito flamenkito self-assigned this Jun 17, 2024
methods: ['toggle', 'show', 'hide', 'selectItemByIndex', 'selectItemByName']
})
@Component({
selector: 'six-sidebar',
changeDetection: ChangeDetectionStrategy.OnPush,
template: '<ng-content></ng-content>',
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
inputs: ['open', 'position', 'toggled', 'width'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would mean we have a breaking change, I guess we could include this in the release which also targets node 18 and above but not before.

cc: @ibirrer

@colinscz colinscz added the breaking change This issue or pull requests causes breaking changes label Jul 22, 2024
@stefanrufer
Copy link
Collaborator

stefanrufer commented Sep 11, 2024

@flamenkito
Suggestion: If the PR is made compatible to V4, we can merge it right away (leave width and just add --width, don't drop inputs. Otherwise we would wait for V5 with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This issue or pull requests causes breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants