-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/six sidebar expose container part #263
base: main
Are you sure you want to change the base?
Conversation
Start to move six-date from popup to popover
Refactor dynamic datepicker children generation Fix styling when hovering over a day that is already selected
Fix six-date hosting
methods: ['toggle', 'show', 'hide', 'selectItemByIndex', 'selectItemByName'] | ||
}) | ||
@Component({ | ||
selector: 'six-sidebar', | ||
changeDetection: ChangeDetectionStrategy.OnPush, | ||
template: '<ng-content></ng-content>', | ||
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property | ||
inputs: ['open', 'position', 'toggled', 'width'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would mean we have a breaking change, I guess we could include this in the release which also targets node 18 and above but not before.
cc: @ibirrer
@flamenkito |
π Linked issue
β Type of change
π Description
Expose
container
part insix-sidebar
for styling.Get rid of
width
parameter in favor of--width
CSS variable.π Checklist
main
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: