Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #217: tab-group vertical scroll bar wiggle #229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

belahorvath
Copy link
Collaborator

πŸ”— Linked issue

#217

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When activating a tab, the font is set to be bold. This naturally leads to the expansion of the content width. I resorted to having a hidden "bold" element added with the ::before selector that has the exact same content as the actual Tab name. This makes it so that there is no expansion if the element is active or not. (I only applied this extra pseudo element if the layout is tab--left or tab--right.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@belahorvath belahorvath changed the title fix #217[,#217] tab-group vertical scroll bar wiggle fix #217: tab-group vertical scroll bar wiggle Mar 20, 2024
@belahorvath belahorvath force-pushed the 217-tab-group-animation-not-smooth branch from c46a91f to ac10f95 Compare March 27, 2024 07:38
@belahorvath belahorvath force-pushed the 217-tab-group-animation-not-smooth branch from ac10f95 to 8f567e9 Compare March 27, 2024 08:15
@belahorvath
Copy link
Collaborator Author

As discussed with @ibirrer we will pause this issue until we have synced internally. We might fix multiple issues at once instead of only addressing the tab group.

@@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

- Fixed `six-checkbox` checkbox-input being distorted with multiline content/text
- Fixed `six-sidebar-item-group` to wrap the sidebar text if it gets too long
- tab group animation smoothing when using left / right layout
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention the component that you adjusted by the tag name, makes it easier to reference the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants