-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major sdk update #62
Major sdk update #62
Conversation
SDK release v3.4.0
Patch 3.4.1 (Hot fix)
Started work on full documentation.
…at fixes in init.md.
…s and functions removed, structure partially changed.
Docs and update readme
Depelopment app example
…es has been defined. Some existing .md files have been changed. Finished utils.md file.
…eral other files.
…n other .md files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs approved
… (now payment_strategy.py).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved updated docs
…d only in code and is not stored in .snet folder.
Got rid of local storage of client configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update docs for config update
@Necr0x0Der Could your please review this one PR? Here we have updated the moment and now private keys are not stored in idenitity. |
Hmmm... The PR is quite large for a comprehensive review for me atm. What I see is that a lot of code was moved from cli to sdk, which is good. Config has become more compact and private keys are not stored, which are also good. This can be easily adopted in sdk in metta. |
Thank you for review, @Necr0x0Der. Yes, proto files stored in We will add the issue of moving service protos to decentralized storage in our backlog. |
Probably there should be 'or' not 'of'? It is in https://github.com/Arondondon/snet-sdk-python/blob/development/docs/metadata_provider/service_metadata.md file
Same here? |
Code from calculator example.
Maybe I'm wrong, but
So, |
Thank you for review, @DaddyWesker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Update includes the following: