#426 - get away from mockables #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for Training in Daemon
raamb
reviewed
Apr 14, 2022
raamb
reviewed
Apr 14, 2022
added 3 commits
April 21, 2022 14:18
review comments addressed make the model available publicily for any inference calls
add in authorization details as part of incoming message
Alternative to Mockables to run tests without net
raamb
reviewed
May 10, 2022
metrics/clients_test.go
Outdated
| func Test_callHTTPServiceHeartbeat(t *testing.T) { | ||
| serviceURL := "http://demo5343751.mockable.io/heartbeat" | ||
| func (suite *ClientTestSuite) Test_callHTTPServiceHeartbeat() { | ||
| serviceURL := "http://localhost:1111/heartbeat" |
There was a problem hiding this comment.
Lets make the port dynamic - via config file etc
There was a problem hiding this comment.
have removed the hardcoded endpoint from multiple places, the service url end point is specified as a config file , for a test case , dont wanna add a new config for the port number
There was a problem hiding this comment.
e949ae6 - latest commit
Removed hard coding of the url and set it once at the test suite initialization
|
Kudos, SonarCloud Quality Gate passed!
|
raamb
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the build and get away from mockables
#429