Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gettoken for concurrent calls #505

Merged
merged 16 commits into from
Jul 31, 2020
Merged

Gettoken for concurrent calls #505

merged 16 commits into from
Jul 31, 2020

Conversation

anandrgitnirman
Copy link
Contributor

#309
Get a token to make concurrent calls

anandrgitnirman added 5 commits July 16, 2020 12:01
singnet#309
c32b285 
Updated the proto to use Signature of MPE Signature + Block number for security reasons
singnet#309- Renamed Token Service to Token Manager ( as this was cla…
1423966 
…shing with the new grpc token service we have )
singnet#309 - to give back a valid token through grpc calls
a23a658
singnet#309 - Test coverage and implementation of CAS operations in M…
e242f1e 
…emory Storage
singnet#309 - Corrected typos in component ( where service was wringl…
73b587b 
…y replaced wiht manager)
@anandrgitnirman anandrgitnirman changed the title Gettoken - Gettoken for concurrent calls Jul 16, 2020
@coveralls
Copy link

coveralls commented Jul 16, 2020 •
edited
Loading

Coverage Status

Coverage increased (+3.4%) to 67.637% when pulling 2f2bdec on anandrgitnirman:gettoken into 5b58178 on singnet:master.

@vsbogd
Copy link
Member

vsbogd commented Jul 17, 2020

I skimmed the PR looks good to me, but better to be reviewed accurately by someone else.

anandrgitnirman added 5 commits July 20, 2020 18:57
singnet#309 - Bug fix on what to update the planned amount as
115fb53
singnet#308 - Update Planned Amount incrementally
9b7a6c0 
For example so far we have pay per use and say the Signed amount was 100 Cogs ,
Now the user wants to make concurrent calls worth 10 Cogs ( assuming 1Cog = 1call) , the user will need to Sign 110 Cogs . thus the planned amount is 10 Cogs
Now if there is a Pay per use Again , the user will need to Sign in for 111 Cogs ( 110 + 1)
singnet#309 - Updated flow to lock the Channel when you have a Higher…
51d2b60 
… Amount Signature and added test cases accordingly
singnet#309 - Corrected Typo in Handler and return back the error
532a3d9
singnet#309 - Standrdized the header name
ea6f088
vsbogd
vsbogd reviewed Jul 27, 2020
View reviewed changes
escrow/memory_storage.go Outdated Show resolved Hide resolved
vsbogd
vsbogd reviewed Jul 27, 2020
View reviewed changes
escrow/prepaid_service.go Show resolved Hide resolved
snetd/cmd/components.go Show resolved Hide resolved
escrow/token_service.go Show resolved Hide resolved
@vsbogd
Update escrow/token_service.go
fc903f2 
Co-authored-by: Vitaly Bogdanov <[email protected]>
@anandrgitnirman anandrgitnirman mentioned this pull request Jul 29, 2020
Open
@anandrgitnirman anandrgitnirman mentioned this pull request Jul 30, 2020
Open
@anandrgitnirman anandrgitnirman merged commit 1161a35 into singnet:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsbogd vsbogd vsbogd approved these changes

@raamb raamb Awaiting requested review from raamb

@ksridharbabuus ksridharbabuus Awaiting requested review from ksridharbabuus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anandrgitnirman @coveralls @vsbogd