Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make model_type optional when loading from native diffusers format #67

Merged
merged 3 commits into from
Jun 30, 2024

Conversation

noskill
Copy link
Collaborator

@noskill noskill commented Jun 25, 2024

No description provided.

@Necr0x0Der
Copy link
Collaborator

I've got one issue with this PR. When I use diffusers model (folder) with CIm2ImPipe, I got the exceptions at line 104 of pipes.py. self.pipe appears of class StableDiffusionXLPipeline instead of StableDiffusionXLControlNetPipeline whether I pass model_type or not. At least, I'd add the check model_type in _load_pipeline before trying _autopipeline.

@noskill
Copy link
Collaborator Author

noskill commented Jun 27, 2024

Yes, indeed assert is not necessary

Copy link
Collaborator

@Necr0x0Der Necr0x0Der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still propose to use _class and _classxl, when model_type is given, but let's merge it as is for now

@Necr0x0Der Necr0x0Der merged commit d1f0013 into singnet:main Jun 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants