Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.15] [python] Validate byteorder on fastercsx argument arrays #3521

Open
wants to merge 1 commit into
base: release-1.15
Choose a base branch
from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 7, 2025

Backport fbeee6f from #3508

@johnkerl
Copy link
Member

johnkerl commented Jan 7, 2025

This does not successfully backport from main to release-1.15 since we currently have C++20 on main but C++17 on release-1.15

https://github.com/single-cell-data/TileDB-SOMA/actions/runs/12654002797/job/35260823182

  src/tiledbsoma/fastercsx.cc:118:47: error: ‘std::endian’ has not been declared
    118 |     if constexpr (std::endian::native == std::endian::big)

See also #3154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants