Fetch externalServices' courses and use it to detect a new school year start. #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieuwex
force-pushed
the
externalservice-course
branch
from
794741c to
e8f62df
Compare
|
#211 is kinda relevant for the grades part of this |
lieuwex
force-pushed
the
externalservice-course
branch
4 times, most recently
from
746de64 to
11d60c9
Compare
lieuwex
force-pushed
the
develop
branch
2 times, most recently
from
06dfc6b to
3929907
Compare
Email is temp disabled, since I don't really know if all this stuff works cleanly.
lieuwex
force-pushed
the
externalservice-course
branch
from
11d60c9 to
8727cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need to do more to really smoothly support new school years, like not showing grades from the previous school year. Which is harder than it sounds like currently (we need to know for each service if the grade is from the current course or not)