Skip to content

Clean up for rubocop #75

Clean up for rubocop

Clean up for rubocop #75

Triggered via pull request December 14, 2024 03:05
@silugsilug
synchronize #112
silug:rubocop
Status Failure
Total duration 2m 50s
Artifacts

pr_tests.yml

on: pull_request
Puppet Syntax
33s
Puppet Syntax
Puppet Style
30s
Puppet Style
Ruby Style
34s
Ruby Style
File checks
30s
File checks
RELENG checks
28s
RELENG checks
Matrix: Puppet Spec
Fit to window
Zoom out
Zoom in

Annotations

15 errors and 7 warnings
RELENG checks
Process completed with exit code 1.
Ruby Style: lib/puppet/functions/simp_apache/auth.rb#L119
Lint/Syntax: unexpected token kIF_MOD (Using Ruby 2.7 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
Ruby Style: lib/puppet/functions/simp_apache/auth.rb#L120
Lint/Syntax: unexpected token kEND (Using Ruby 2.7 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
Ruby Style: lib/puppet/functions/simp_apache/auth.rb#L126
Lint/Syntax: unexpected token kEND (Using Ruby 2.7 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
Ruby Style: lib/puppet/functions/simp_apache/auth.rb#L135
Lint/Syntax: unexpected token kEND (Using Ruby 2.7 parser; configure using `TargetRubyVersion` parameter, under `AllCops`)
Ruby Style: lib/puppet/provider/htaccess/htaccess.rb#L83
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Ruby Style: lib/puppet/provider/htaccess/htaccess.rb#L115
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Ruby Style: lib/puppet/provider/htaccess/htaccess.rb#L135
Lint/RescueException: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? (https://rubystyle.guide#no-blind-rescues)
Ruby Style: spec/acceptance/suites/htaccess/htaccess_spec.rb#L7
RSpec/IndexedLet: This `let` statement uses `1` in its name. Please give it a meaningful name. (https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IndexedLet)
Ruby Style: spec/acceptance/suites/htaccess/htaccess_spec.rb#L14
RSpec/IndexedLet: This `let` statement uses `2` in its name. Please give it a meaningful name. (https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IndexedLet)
Ruby Style: spec/acceptance/suites/htaccess/htaccess_spec.rb#L22
RSpec/IndexedLet: This `let` statement uses `3` in its name. Please give it a meaningful name. (https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IndexedLet)
Puppet Spec (Puppet 8.x, ~> 8.0, 3.2, false): spec/functions/simp_apache/auth_spec.rb#L39
simp_apache::auth with valid input generates apache settings for enabled file auth method Failure/Error: is_expected.to run.with_params(file_auth_hash).and_return(expected_output.strip) SyntaxError: --> /home/runner/work/pupmod-simp-simp_apache/pupmod-simp-simp_apache/spec/fixtures/modules/simp_apache/lib/puppet/functions/simp_apache/auth.rb Unmatched `{', missing `}' ?Unmatched `(', missing `)' ? 5 Puppet::Functions.create_function(:'simp_apache::auth') do 89 def auth_ldap(opts, content) 117 if opts['binddn'] > 118 content << "AuthLDAPBindDN \"#{opts['binddn']}\"" > 119 content << "AuthLDAPBindPassword '#{opts['bindpw'].gsub(''', "\\\\'")}'" if opts['bindpw'] 120 end 126 end 135 end /home/runner/work/pupmod-simp-simp_apache/pupmod-simp-simp_apache/spec/fixtures/modules/simp_apache/lib/puppet/functions/simp_apache/auth.rb:119: syntax error, unexpected `if' modifier, expecting ')' (SyntaxError�[m)�[m ...ndpw'].gsub(''', "\\\\'")}'" if opts['bindpw']�[m ... ^~�[m /home/runner/work/pupmod-simp-simp_apache/pupmod-simp-simp_apache/spec/fixtures/modules/simp_apache/lib/puppet/functions/simp_apache/auth.rb:120: syntax error, unexpected `end', expecting '}'�[m end�[m ^~~�[m /home/runner/work/pupmod-simp-simp_apache/pupmod-simp-simp_apache/spec/fixtures/modules/simp_apache/lib/puppet/functions/simp_apache/auth.rb:126: syntax error, unexpected `end', expecting '}'�[m end�[m ^~~�[m /home/runner/work/pupmod-simp-simp_apache/pupmod-simp-simp_apache/spec/fixtures/modules/simp_apache/lib/puppet/functions/simp_apache/auth.rb:135: syntax error, unexpected `end', expecting '}'�[m
Puppet Spec (Puppet 8.x, ~> 8.0, 3.2, false)
Process completed with exit code 1.
Puppet Spec (Puppet 7.x [SIMP 6.6/PE 2021.7], ~> 7.0, 2.7, false): spec/functions/simp_apache/auth_spec.rb#L39
simp_apache::auth with valid input generates apache settings for enabled file auth method Failure/Error: is_expected.to run.with_params(file_auth_hash).and_return(expected_output.strip) SyntaxError: /home/runner/work/pupmod-simp-simp_apache/pupmod-simp-simp_apache/spec/fixtures/modules/simp_apache/lib/puppet/functions/simp_apache/auth.rb:119: syntax error, unexpected `if' modifier, expecting ')' ...ndpw'].gsub(''', "\\\\'")}'" if opts['bindpw'] ... ^~ /home/runner/work/pupmod-simp-simp_apache/pupmod-simp-simp_apache/spec/fixtures/modules/simp_apache/lib/puppet/functions/simp_apache/auth.rb:120: syntax error, unexpected `end', expecting '}' end ^~~ /home/runner/work/pupmod-simp-simp_apache/pupmod-simp-simp_apache/spec/fixtures/modules/simp_apache/lib/puppet/functions/simp_apache/auth.rb:126: syntax error, unexpected `end', expecting '}' end ^~~ /home/runner/work/pupmod-simp-simp_apache/pupmod-simp-simp_apache/spec/fixtures/modules/simp_apache/lib/puppet/functions/simp_apache/auth.rb:135: syntax error, unexpected `end', expecting '}'
Puppet Spec (Puppet 7.x [SIMP 6.6/PE 2021.7], ~> 7.0, 2.7, false)
Process completed with exit code 1.
RELENG checks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
File checks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Puppet Style
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Puppet Syntax
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Ruby Style
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Puppet Spec (Puppet 8.x, ~> 8.0, 3.2, false)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Puppet Spec (Puppet 7.x [SIMP 6.6/PE 2021.7], ~> 7.0, 2.7, false)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636