bummer

simgrid · May 24, 2024 · 939ce22 · 939ce22
1 parent 14b10eb
commit 939ce22
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 28 deletions.
diff --git a/include/fsmod/FileSystem.hpp b/include/fsmod/FileSystem.hpp
@@ -23,6 +23,7 @@ namespace simgrid::fsmod {
         int max_num_open_files_;
 
     public:
+        explicit FileSystem(std::string name, int max_num_open_files) : name_(std::move(name)), max_num_open_files_(max_num_open_files) {};
         static std::shared_ptr<FileSystem> create(const std::string &name, int max_num_open_files = 1024);
 
         void mount_partition(const std::string &mount_point, std::shared_ptr<Storage> storage, sg_size_t size,
@@ -49,8 +50,6 @@ namespace simgrid::fsmod {
         [[nodiscard]] std::shared_ptr<Partition> partition_by_name(const std::string& name) const;
         [[nodiscard]] std::shared_ptr<Partition> partition_by_name_or_null(const std::string& name) const;
 
-    protected:
-        explicit FileSystem(std::string name, int max_num_open_files) noexcept: name_(std::move(name)), max_num_open_files_(max_num_open_files) {};
 
     private:
         [[nodiscard]] std::pair<std::shared_ptr<Partition>, std::string> find_path_at_mount_point(const std::string &full_path) const;

diff --git a/sonar-project.properties b/sonar-project.properties
diff --git a/src/FileSystem.cpp b/src/FileSystem.cpp
@@ -39,7 +39,7 @@ namespace simgrid::fsmod {
     /*********************** PUBLIC INTERFACE *****************************/
 
     std::shared_ptr<FileSystem> FileSystem::create(const std::string &name, int max_num_open_files) {
-        return std::make_shared<FileSystem>(FileSystem(name, max_num_open_files));
+        return std::make_shared<FileSystem>(name, max_num_open_files);
     }
 
     /**