Skip to content

Commit

Permalink
Some documentation simplification
Browse files Browse the repository at this point in the history
  • Loading branch information
henricasanova committed Apr 22, 2024
1 parent 96289c7 commit 2f3dce0
Show file tree
Hide file tree
Showing 10 changed files with 26 additions and 72 deletions.
17 changes: 0 additions & 17 deletions doc/source/api_user.rst

This file was deleted.

9 changes: 0 additions & 9 deletions doc/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,8 @@

# The full version, including alpha/beta/rc tags

breathe_projects = {
"user": "../../docs/2.2-dev/user/xml/"
}
version = '0.1-dev'
release = '0.1-dev'


breathe_projects = {
"user": "../../docs/0.1/user/xml/",
"developer": "../../docs/0.1/developer/xml/",
"internal": "../../docs/0.1/internal/xml/",
}
version = '0.1'
release = '0.1'
Expand Down
6 changes: 0 additions & 6 deletions doc/source/getting_started.rst

This file was deleted.

Binary file modified doc/source/images/simgrid_logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 9 additions & 6 deletions doc/source/index.rst
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
.. _mainpage:

.. figure:: images/simgrid_logo.png
:scale: 20%

TO WRITE
The SimGrid File System Module: API Reference
*********************************************

Explore the API using the left search box and navigation bar.


.. toctree::
installation.rst
getting_started.rst
api_user.rst
:hidden:
:glob:

api_user/*

25 changes: 0 additions & 25 deletions doc/source/installation.rst

This file was deleted.

15 changes: 10 additions & 5 deletions include/FileSystem.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
namespace simgrid::module::fs {

/**
* @brief A CLASS
*/
* @brief A class that implements a file system abstraction
*/
class XBT_PUBLIC FileSystem {

const std::string name_;
Expand All @@ -29,9 +29,6 @@ namespace simgrid::module::fs {
void mount_partition(const std::string &mount_point, std::shared_ptr<Storage> storage, sg_size_t size);
void mount_partition(const std::string &mount_point, std::shared_ptr<Storage> storage, const std::string& size);

[[nodiscard]] std::shared_ptr<Partition> partition_by_name(const std::string& name) const;
[[nodiscard]] std::shared_ptr<Partition> partition_by_name_or_null(const std::string& name) const;

void create_file(const std::string& full_path, sg_size_t size);
void create_file(const std::string& full_path, const std::string& size);

Expand All @@ -43,6 +40,12 @@ namespace simgrid::module::fs {
[[nodiscard]] sg_size_t file_size(const std::string& full_path) const;

std::shared_ptr<File> open(const std::string& full_path);

/** \cond EXCLUDE_FROM_DOCUMENTATION */

[[nodiscard]] std::shared_ptr<Partition> partition_by_name(const std::string& name) const;
[[nodiscard]] std::shared_ptr<Partition> partition_by_name_or_null(const std::string& name) const;

virtual ~FileSystem() = default;

protected:
Expand All @@ -55,6 +58,8 @@ namespace simgrid::module::fs {

int num_open_files_ = 0;

/** \endcond */

};

} // namespace simgrid::module::fs
Expand Down
5 changes: 3 additions & 2 deletions src/FileSystem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@
#include "FileSystemException.hpp"

namespace simgrid::module::fs {

/**
* @brief Private method to find the partition and path at mount point for an absolute path
* @param full_path: an absolute simplified file path
* @param simplified_path: an absolute simplified file path
* @return
*/
std::pair<std::shared_ptr<Partition>, std::string>
Expand Down Expand Up @@ -220,4 +221,4 @@ namespace simgrid::module::fs {



}
}
3 changes: 2 additions & 1 deletion src/JBODStorage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ namespace simgrid::module::fs {
}
/**
* @brief Method to create an instance of a JBOD (Just a Bunch of Disks) storage
* @param disks: the disks
* @param name: the storage's name
* @param disks: the storage's disks
* @return
*/
std::shared_ptr<JBODStorage> JBODStorage::create(const std::string& name, const std::vector<s4u::Disk*>& disks) {
Expand Down
3 changes: 2 additions & 1 deletion src/OneDiskStorage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ namespace simgrid::module::fs {

/**
* @brief Method to create an instance of a one-disk storage
* @param disk: the disk
* @param name: the storage's name
* @param disk: the storage's disk
* @return
*/
std::shared_ptr<OneDiskStorage> OneDiskStorage::create(const std::string& name, s4u::Disk* disk) {
Expand Down

0 comments on commit 2f3dce0

Please sign in to comment.