-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sse4.2: first attempt at implementing mm_cmpestra #280
sse4.2: first attempt at implementing mm_cmpestra #280
Conversation
please tell me if I am going in right direction in implementation of the function and generating test cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. A lot of the issues I see right away are relatively minor, but hopefully they'll make the code a little easier to understand, which should make it easier to optimize in the future.
Thank You for the review, it will take some time to go through all of this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Another issue from https://github.com/nemequ/simde/pull/280/checks?check_run_id=662532291#step:5:66
That is odd, Travis CI hasn't seen the latest commit .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent progress! I added some more comments, but don't get discouraged. These functions are definitely a bit of a pani to implement (which is a big part of why they're not implemented yet), and you're doing really well. I just want to be a bit pedantic about this first function since it's probably going to be a model for the others.
I've tried to explain the reasons for each change, but if there is anything you're not clear on please ask.
fc0618d
to
cfe4b7f
Compare
The implementation looks good to me. As soon as you have the tests done we can merge it. |
I am working on it, hopefully I will be able to finish it by today. |
Closing in favor of #295 |
sse4.2: first attempt at implementing mm_cmpestra