-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vqdmulhs_s32 native alias. #1257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, @Syonyk . I'm going to add more native alias testing to this PR before I merge it, so please don't push anymore to this branch.
Sounds good, I'm trying to keep my pull requests as simple and "one item" as possible, so you're free to do what you need with this branch. |
391b100
to
ed9ea8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll sort something out for tests. |
Test pushed, generated on the GCE ARM box. Though I admit I'm not sure how this tests the native alias, as the tests all use the simde_ prefix. |
Thank you!
https://github.com/simd-everywhere/simde/blob/master/test/native-aliases.sh strips the |
Function prototype has two parameters: simde_vqdmulhs_s32(int32_t a, int32_t b) Native define only had one. This does not build. Tests only ever called with the simde_ prefix.
This reverts commit 403e942.
With 59645b6 temporarily reverting your native alias fix, we should see confirmation that it worked at the native-aliases-arm64 CI check (that CI job should fail, since it lacks your fix) and it indeed fails where it should in both the arm64 native aliases test and the amd64 native aliases test |
Fixed in f56ef45 ; thank you! |
Function prototype has two parameters:
simde_vqdmulhs_s32(int32_t a, int32_t b)
Native define only had one. This does not build.
Tests only ever called with the simde_ prefix.