Skip to content

Commit

Permalink
Merge branch '3.0' into 3
Browse files Browse the repository at this point in the history
  • Loading branch information
emteknetnz committed Jan 8, 2025
2 parents 0d52936 + 4ea6402 commit 9989be2
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 14 deletions.
3 changes: 1 addition & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
"require": {
"php": "^8.3",
"silverstripe/framework": "^6",
"symfony/cache": "^7.0",
"silverstripe/vendor-plugin": "^2"
"symfony/cache": "^7.0"
},
"require-dev": {
"silverstripe/recipe-testing": "^4",
Expand Down
1 change: 0 additions & 1 deletion src/DataDifferencer.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

use SilverStripe\Assets\Image;
use SilverStripe\Core\Convert;
use SilverStripe\Dev\Deprecation;
use SilverStripe\ORM\DataObject;
use SilverStripe\Model\List\ArrayList;
use SilverStripe\ORM\FieldType\DBField;
Expand Down
12 changes: 1 addition & 11 deletions src/Versioned.php
Original file line number Diff line number Diff line change
Expand Up @@ -1987,20 +1987,10 @@ public function stagesDifferRecursive(): bool
* @param string $sort
* @param string $limit
* @param string $join Deprecated, use leftJoin($table, $joinClause) instead
* @param string $having @deprecated 2.2.0 The $having parameter does nothing and will be removed without
* equivalent functionality to replace it
* @return ArrayList<Versioned_Version>
*/
public function Versions($filter = "", $sort = "", $limit = "", $join = "", $having = "")
public function Versions($filter = "", $sort = "", $limit = "", $join = "")
{
if ($having) {
Deprecation::withSuppressedNotice(function () {
$message = 'The $having parameter does nothing and will be removed without equivalent'
. ' functionality to replace it';
Deprecation::notice('2.2.0', $message);
});
}

$owner = $this->owner;

// When an object is not yet in the Database, we can't get its versions
Expand Down

0 comments on commit 9989be2

Please sign in to comment.