-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX re-label forgot password for uniq id #11568
FIX re-label forgot password for uniq id #11568
Conversation
e2853d9
to
c5843c9
Compare
c5843c9
to
7e5eeb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just noticed the branch this is targetting. No sense in this waiting until June - can you please retarget to 5.3
so it can be released as a patch?
Would be really good if you can include a unit test as well, if you have time.
7e5eeb2
to
194bcbe
Compare
8798fa1
to
0e82c28
Compare
Alrighty @GuySartorelli I think I'm done messing about 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this
Description
Defaults for non-Email unique identifier fields, including a TextField in the form and a sensible label.
Manual testing steps
Set
unique_identifier_field
to something non-email.See that it changes the field label.
Issues
Fixes #11567
Pull request checklist