Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting an indentation using indentMultiplier #1212

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

mufeedali
Copy link
Contributor

This is kind of a proof of concept for #1188 . Here, the indentation will be set to 2 * indentMultiplier where indentMultiplier is an optional number type option the user can set in SETTINGS. The paddings in the CSS are also calculated on this basis.

This also doesn't cause any conflicts or other issues with the "four spaces = code block" behavior.

@mufeedali
Copy link
Contributor Author

Any ideas to do this more cleanly would be appreciated. :) (Especially the css and how to set --editor-indent-multiplier from the code.)

@zefhemel
Copy link
Collaborator

zefhemel commented Feb 1, 2025

While I still don't really see one would want it, I don't have strong objections to merging it and it seems to work as advertised 👍🏻

@zefhemel zefhemel merged commit c27c83b into silverbulletmd:main Feb 1, 2025
1 check passed
@mufeedali mufeedali deleted the indent-poc branch February 3, 2025 08:00
@mufeedali
Copy link
Contributor Author

While I still don't really see one would want it

I just like 4 spaces better and have a ton of existing notes using 4 spaces. 😅 Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants