Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 10.6.0 #233

Merged
merged 12 commits into from
Oct 25, 2023
Merged

Release 10.6.0 #233

merged 12 commits into from
Oct 25, 2023

Conversation

forevermatt
Copy link
Contributor

Added

  • Add jsdocs and a missing type

Fixed

  • Only have the Select component dispatch populated events on initial load or changes to the list of options
    • This fixes a problem where, when the Select's value is changed (by the user), the change and populated events are both dispatched, even if the list of options is unchanged. Those subsequent dispatches of the populated event made it too easy for consumers of this component to accidentally set the value of the Select back to what it was an instant before, effectively preventing the user's choice from "sticking" sometimes.

hobbitronics and others added 12 commits October 6, 2023 11:37
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.3 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…/babel/traverse-7.23.2

build(deps-dev): bump @babel/traverse from 7.21.3 to 7.23.2
This fixes a problem where, when the Select's value is changed (by the
user), the `change` and `populated` events are both dispatched, even if
the list of options is unchanged.

Those subsequent dispatches of the `populated` event make it too easy
for consumers of this component to accidentally set the value of the
Select back to what it was an instant before, effectively preventing
the user's choice from "sticking" sometimes.
…lated-event-dispatches

Only dispatch Select's `populated` event when appropriate
@forevermatt forevermatt requested review from hobbitronics and a team October 25, 2023 13:50
@forevermatt forevermatt merged commit dd04411 into main Oct 25, 2023
@hobbitronics
Copy link
Contributor

🎉 This PR is included in version 10.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants