Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dry-run-mode flag #73

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

jason-jackson
Copy link
Contributor

Removed

  • Removed --dry-run-mode flag (deprecated)

@jason-jackson jason-jackson requested a review from a team April 24, 2024 21:54
@briskt
Copy link
Contributor

briskt commented Apr 25, 2024

This looks good as it is. Are you planning to work through all of the breaking-change issues in the near future? If not, let's hold of on merging this for now.

@jason-jackson
Copy link
Contributor Author

This looks good as it is. Are you planning to work through all of the breaking-change issues in the near future? If not, let's hold of on merging this for now.

Yeah, I can do that, do you want them all in this PR, or do you want to merge them all to develop, then to main?

@briskt
Copy link
Contributor

briskt commented Apr 25, 2024

This looks good as it is. Are you planning to work through all of the breaking-change issues in the near future? If not, let's hold of on merging this for now.

Yeah, I can do that, do you want them all in this PR, or do you want to merge them all to develop, then to main?

No, it's probably too much for one PR. You could start a pre-release branch if you think it would stretch out for a while or just merge into develop and then do one release PR when you're done.

@jason-jackson jason-jackson changed the base branch from develop to release/v4.0.0 April 29, 2024 18:41
@jason-jackson jason-jackson merged commit d210a73 into release/v4.0.0 Apr 29, 2024
3 checks passed
@jason-jackson jason-jackson deleted the feature/remove-dry-run branch April 29, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants