Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remember_me_preference cookie #302

Merged
merged 1 commit into from
Dec 13, 2024
Merged

add remember_me_preference cookie #302

merged 1 commit into from
Dec 13, 2024

Conversation

hobbitronics
Copy link
Contributor

IDP-105 Set cookie to not check remember me box if user unchecks it when logging in so we don't default it checked again in the future.

IDP-108 Keep "Remember me" unchecked if the user unchecks it (at least during a single login)

@hobbitronics hobbitronics requested a review from a team as a code owner December 13, 2024 06:26
@hobbitronics hobbitronics requested review from briskt, forevermatt, mtompset and jason-jackson and removed request for a team December 13, 2024 06:26
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good implementation

modules/mfa/src/Auth/Process/Mfa.php Show resolved Hide resolved
@hobbitronics hobbitronics merged commit b2fdcda into main Dec 13, 2024
4 checks passed
@hobbitronics hobbitronics deleted the remember-me-mfa branch December 13, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants