Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix maskEmail to handle subdomains correctly #301

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix maskEmail to handle subdomains correctly #301

merged 2 commits into from
Dec 10, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Dec 7, 2024

No description provided.

@briskt briskt requested a review from a team as a code owner December 7, 2024 06:14
@briskt briskt requested review from forevermatt, mtompset, jason-jackson and hobbitronics and removed request for a team December 7, 2024 06:14
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a bit hard to parse for my weak php so offering an alternative if you like.

modules/mfa/src/Auth/Process/Mfa.php Outdated Show resolved Hide resolved
modules/mfa/src/Auth/Process/Mfa.php Outdated Show resolved Hide resolved
modules/mfa/tests/MfaTest.php Outdated Show resolved Hide resolved
@briskt briskt merged commit 8dab752 into main Dec 10, 2024
4 checks passed
@briskt briskt deleted the fix-email-mask branch December 10, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants