Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix config-shim parameters #293

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix config-shim parameters #293

merged 1 commit into from
Nov 27, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Nov 27, 2024

Fixed

  • Fixed the run.sh script so it doesn't try to use the -u and --strategy flags on config-shim if STRATEGY_ID is empty.

@briskt briskt requested a review from a team as a code owner November 27, 2024 05:57
@briskt briskt requested review from forevermatt, mtompset, jason-jackson and hobbitronics and removed request for a team November 27, 2024 05:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt briskt merged commit 71efbbd into main Nov 27, 2024
3 checks passed
@briskt briskt deleted the fix-config-shim branch November 27, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praveenraj-K Praveenraj-K Praveenraj-K approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @Praveenraj-K