PR feedback: rewrite domain mask for clarity

silinternational · Dec 10, 2024 · ad9ee0f · ad9ee0f
1 parent 8c80b6d
commit ad9ee0f
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/modules/mfa/src/Auth/Process/Mfa.php b/modules/mfa/src/Auth/Process/Mfa.php
@@ -912,9 +912,16 @@ public static function maskEmail(string $email): string
          * Add an '*' for each of the characters of the domain, except
          * for the first character of each part and the .
          */
-        $newEmail .= implode('.', array_map(function ($part) {
-            return substr($part, 0, 1) . str_repeat('*', max(strlen($part) - 1, 0));
-        }, explode('.', $domain)));
+        $domainParts = explode('.', $domain);
+        $maskedDomain = '';
+
+        foreach ($domainParts as $part) {
+            $firstCharacter = substr($part, 0, 1);
+            $maskedPart = $firstCharacter . str_repeat('*', max(strlen($part) - 1, 0));
+            $maskedDomain .= $maskedPart . '.';
+        }
+        $maskedDomain = rtrim($maskedDomain, '.');
+        $newEmail .= $maskedDomain;
         return $newEmail;
     }