fix google analytics and use don't use inline onclick

silinternational · Nov 26, 2024 · 81b1ecd · 81b1ecd
1 parent 8d021d8
commit 81b1ecd
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/modules/material/themes/material/default/selectidp-links.twig b/modules/material/themes/material/default/selectidp-links.twig
@@ -14,9 +14,21 @@
       idpInput.value = id;
 
       document.querySelector('form').appendChild(idpInput);
-
-      ga('send', 'event', 'hub', 'choice', 'IdP', id);
+      gtag('event', 'IdP', {
+        'event_category': 'hub',
+        'event_label': 'choice',
+        'value': id
+      });
+      document.querySelector('form').submit();
     }
+    
+    document.addEventListener('DOMContentLoaded', () => {
+      document.querySelectorAll('button[data-entityid]').forEach((idp) => {
+        idp.addEventListener('click', () => {
+          setSelectedIdp(idp.dataset.entityid);
+        });
+      });
+    });
 
     function clickedAnyway(idpName) {
       ga('send', 'event', 'hub', 'choice-disabled', 'IdP', idpName);
@@ -61,7 +73,7 @@
           title="{{ '{selectidp-links:enabled}'|trans({'%idpName%': idp|entityDisplayName}) }}"
         >
           <div class="mdl-card__media white-bg fixed-height">
-            <button class="mdl-button logo-container fill-parent" onclick="setSelectedIdp('{{ idp.entityid|e }}')">
+            <button data-entityid="{{idp.entityid|e}}" type="button" class="mdl-button logo-container fill-parent">
               <div class="image-wrapper">
                 <img
                   class="logo"