Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 7.0.10 - Add missing healthcheck for local-development "broker" container #303

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Release 7.0.10 - Add missing healthcheck for local-development "broker" container #303

merged 1 commit into from
Jan 8, 2025

Conversation

forevermatt
Copy link
Contributor

WAITING FOR

Incremental progress towards addressing
IDP-1335 idp-pw-api alert #25: CVE-2024-52806

Fixed

  • Add missing healthcheck for local "broker" container

PR Checklist

  • Put version number in PR title (e.g. Release x.y.z - Summary of changes)
  • Documentation (README, etc.)
  • Unit tests created or updated
  • Run make composershow

@forevermatt forevermatt requested a review from a team as a code owner January 8, 2025 16:44
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mtompset
mtompset approved these changes Jan 8, 2025
View reviewed changes
Copy link

@mtompset mtompset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'nc' may not exist in the docker images used. Make sure the Dockerfile installs it.

Base automatically changed from feature/fix-local-dev-for-mac-chips to main January 8, 2025 20:46
@forevermatt
Copy link
Contributor Author

'nc' may not exist in the docker images used. Make sure the Dockerfile installs it.

Thanks, I hadn't thought of that. It turns out netcat is installed in our silintl/php8 docker image, which ID Broker is built on, so it's there.

@forevermatt forevermatt merged commit 86edf24 into main Jan 8, 2025
4 checks passed
@forevermatt forevermatt deleted the feature/add-missing-local-healthcheck branch January 8, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtompset mtompset mtompset approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forevermatt @mtompset