Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused variable WEBAUTHN_RP_ORIGIN #295

Merged
merged 1 commit into from
Nov 6, 2024
Merged

remove unused variable WEBAUTHN_RP_ORIGIN #295

merged 1 commit into from
Nov 6, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Nov 5, 2024

Removed

  • Removed WEBAUTHN_RP_ORIGIN. This is a BREAKING CHANGE.

PR Checklist

  • Put version number in PR title (e.g. Release x.y.z - Summary of changes)
  • Documentation (README, local.env.dist, etc.)
  • Unit tests created or updated
  • Run make composershow

@briskt briskt requested review from a team as code owners November 5, 2024 02:02
@briskt briskt requested review from forevermatt, mtompset, jason-jackson and hobbitronics and removed request for a team November 5, 2024 02:02
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

forevermatt
forevermatt approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you waiting to do a release of this (since there's no release number in the PR title)?

@briskt
Copy link
Contributor Author

briskt commented Nov 6, 2024

Are you waiting to do a release of this (since there's no release number in the PR title)?

Yes, and still waffling a bit on whether this should bump the major version number.

@briskt briskt merged commit 81fc511 into main Nov 6, 2024
3 checks passed
@briskt briskt deleted the rm-var branch November 6, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praveenraj-K Praveenraj-K Praveenraj-K approved these changes

@forevermatt forevermatt forevermatt approved these changes

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briskt @forevermatt @Praveenraj-K