Merge pull request #139 from silinternational/develop

Release 4.3.1 If syncAll() throws an exception, make sure it gets logged and emailed
silinternational · Nov 14, 2022 · 35eb8d0 · 35eb8d0
2 parents 6cdc05a + ce23a9f
commit 35eb8d0
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/application/common/sync/Synchronizer.php b/application/common/sync/Synchronizer.php
@@ -376,6 +376,28 @@ public static function isValidSafetyCutoff($value)
         return is_numeric($value) && ($value >= 0.0);
     }
 
+
+    /**
+     * Do a full synchronization, requesting all users from the ID Store and
+     * updating all records in the ID Broker.
+     *
+     * If there is an exception, send out an email about it.
+     */
+    public function syncAllNotifyException()
+    {
+        try {
+            $this->syncAll();
+        } catch (Exception $e) {
+            $message = sprintf(
+                'There was an error with the sync process. Code: %s, Message: %s',
+                $e->getCode(),
+                $e->getMessage(),
+            );
+            $this->logger->error($message);
+        }
+    }
+
+
     /**
      * Do a full synchronization, requesting all users from the ID Store and
      * updating all records in the ID Broker.

diff --git a/application/console/controllers/BatchController.php b/application/console/controllers/BatchController.php
@@ -12,7 +12,7 @@ class BatchController extends Controller
     public function actionFull()
     {
         $synchronizer = $this->getSynchronizer();
-        $synchronizer->syncAll();
+        $synchronizer->syncAllNotifyException();
     }
 
     /**