add argument tests when creating AdminEventRepository

Related to: aliencube#319
sikutisa · Sep 16, 2024 · c03125b · c03125b
1 parent ea8c726
commit c03125b
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/src/AzureOpenAIProxy.ApiApp/Repositories/AdminEventRepository.cs b/src/AzureOpenAIProxy.ApiApp/Repositories/AdminEventRepository.cs
@@ -45,8 +45,8 @@ public interface IAdminEventRepository
 /// </summary>
 public class AdminEventRepository(TableServiceClient tableServiceClient, StorageAccountSettings storageAccountSettings) : IAdminEventRepository
 {
-    private readonly TableServiceClient _tableServiceClient = tableServiceClient ?? throw new ArgumentException(nameof(tableServiceClient));
-    private readonly StorageAccountSettings _storageAccountSettings = storageAccountSettings ?? throw new ArgumentException(nameof(storageAccountSettings));
+    private readonly TableServiceClient _tableServiceClient = tableServiceClient ?? throw new ArgumentNullException(nameof(tableServiceClient));
+    private readonly StorageAccountSettings _storageAccountSettings = storageAccountSettings ?? throw new ArgumentNullException(nameof(storageAccountSettings));
 
     /// <inheritdoc />
     public async Task<AdminEventDetails> CreateEvent(AdminEventDetails eventDetails)

diff --git a/test/AzureOpenAIProxy.ApiApp.Tests/Repositories/AdminEventRepositoryTests.cs b/test/AzureOpenAIProxy.ApiApp.Tests/Repositories/AdminEventRepositoryTests.cs
@@ -29,6 +29,34 @@ public void Given_ServiceCollection_When_AddAdminEventRepository_Invoked_Then_It
         services.SingleOrDefault(p => p.ServiceType == typeof(IAdminEventRepository)).Should().NotBeNull();
     }
 
+    [Fact]
+    public void Given_Null_TableServiceClient_When_Creating_AdminEventRepository_Then_It_Should_Throw_Exception()
+    {
+        // Arrange
+        var settings = Substitute.For<StorageAccountSettings>();
+        var tableServiceClient = default(TableServiceClient);
+
+        // Act
+        Action action = () => new AdminEventRepository(tableServiceClient, settings);
+
+        // Assert
+        action.Should().Throw<ArgumentNullException>();
+    }
+
+    [Fact]
+    public void Given_Null_StorageAccountSettings_When_Creating_AdminEventRepository_Then_It_Should_Throw_Exception()
+    {
+        // Arrange
+        var settings = default(StorageAccountSettings);
+        var tableServiceClient = Substitute.For<TableServiceClient>();
+
+        // Act
+        Action action = () => new AdminEventRepository(tableServiceClient, settings);
+
+        // Assert
+        action.Should().Throw<ArgumentNullException>();
+    }
+
     [Fact]
     public void Given_Instance_When_CreateEvent_Invoked_Then_It_Should_Throw_Exception()
     {