Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial membership documentation #54

Merged
merged 6 commits into from
Aug 3, 2022
Merged

Add initial membership documentation #54

merged 6 commits into from
Aug 3, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 10, 2022

Summary

  • Pick the commit from kubernetes to give some attribution for the already existing documentation kubernetes/community@f1222b4
  • Adding initial membership documentation that we can iterate over to refine and make that align with Sigstore organization.

Need to add some documentation regarding the GitHub org, which I will push in a follow-up PR

/cc @lukehinds @bobcallaway @dlorenc

Ticket Link

xref: sigstore/sigstore#305 / #53

Release Note

NONE

@cpanato cpanato force-pushed the membershio-docs branch 2 times, most recently from 0523230 to 6ab653f Compare March 10, 2022 12:21
bobcallaway
bobcallaway reviewed Mar 10, 2022
View reviewed changes
OWNERS.md Outdated Show resolved Hide resolved
@cpanato
Copy link
Member Author

cpanato commented Mar 11, 2022

when have some free cycle i would love to get some feedback @dlorenc @lukehinds

@dlorenc
Copy link
Member

dlorenc commented Mar 11, 2022

This looks like a great start to me! No concerns.

@cpanato cpanato requested a review from bobcallaway March 21, 2022 15:26
bobcallaway
bobcallaway reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, a couple questions

.github/ISSUE_TEMPLATE/membership.yml Outdated Show resolved Hide resolved
community-membership.md Outdated Show resolved Hide resolved
community-membership.md Outdated
- Mentor contributors and reviewers
- May approve code contributions for acceptance

## Inactive members
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - based on the current membership of the sigstore organization, what % of folks there would be considered inactive/active based on the definitions above?

@lukehinds
Copy link
Member

Sorry I missed this late time around. In regards to folks joining the org, we are right now maxed out and cannot take anymore on due to githubs default limits.

@dlorenc
Copy link
Member

dlorenc commented Mar 21, 2022

Sorry I missed this late time around. In regards to folks joining the org, we are right now maxed out and cannot take anymore on due to githubs default limits.

I think we have a few options to fix this - but we can do "outside contributor" for right now.

@lukehinds lukehinds mentioned this pull request Mar 24, 2022
Closed
haydentherapper
haydentherapper reviewed Apr 8, 2022
View reviewed changes
community-membership.md Outdated Show resolved Hide resolved
community-membership.md Outdated Show resolved Hide resolved
community-membership.md Outdated Show resolved Hide resolved
community-membership.md Outdated Show resolved Hide resolved
community-membership.md Outdated Show resolved Hide resolved
@naveensrinivasan
Copy link

What is the status of this PR? This can help the other OpenSSF communities trying to do something similar.

@cpanato
Copy link
Member Author

cpanato commented Jul 28, 2022

What is the status of this PR? This can help the other OpenSSF communities trying to do something similar.

i will update and get back to this early next week

@naveensrinivasan
Copy link

What is the status of this PR? This can help the other OpenSSF communities trying to do something similar.

i will update and get back to this early next week

👍

@haydentherapper
Copy link
Contributor

@cpanato Would you like any help with the updates? Happy to collaborate.

mrbobbytables and others added 5 commits August 3, 2022 10:37
@mrbobbytables @cpanato
Update github org membership requirements
1e8c86f 
Membership across orgs is now equivalent. When joining a Kubernetes
GitHub Org, you are now joining the Kubernetes project and have
implicit membership in the other active orgs.

ref: kubernetes/org#966
Signed-off-by: cpanato <[email protected]>
@cpanato
rename CONTRIBUTORS to CONTRIBUTING
ee635e5 
Signed-off-by: cpanato <[email protected]>
@cpanato
small update in the readme
4b4bdd3 
Signed-off-by: cpanato <[email protected]>
@cpanato
add initial community membership document
3b3bde9 
Signed-off-by: cpanato <[email protected]>
@cpanato
update Dan and Bob company affiliations
b918be8 
Signed-off-by: cpanato <[email protected]>
@cpanato
Copy link
Member Author

cpanato commented Aug 3, 2022

@haydentherapper @naveensrinivasan @bobcallaway did some updates, can I get another review round and let me know what is missing or need to update.
You can also push changes to the PR if you want :)

thanks so much for all the feedback

@dlorenc
Copy link
Member

dlorenc commented Aug 3, 2022

This seems like a good start to me!

bobcallaway
bobcallaway previously approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well

@lukehinds lukehinds self-requested a review August 3, 2022 12:38
lukehinds
lukehinds reviewed Aug 3, 2022
View reviewed changes
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo, but other than that lgtm

@cpanato
update readme
335b682 
Signed-off-by: cpanato <[email protected]>
@cpanato cpanato requested a review from bobcallaway August 3, 2022 14:09
@cpanato
Copy link
Member Author

cpanato commented Aug 3, 2022

need another lgtm after the rebase with the typo fix

@lukehinds lukehinds merged commit 4996cf1 into sigstore:main Aug 3, 2022
@cpanato cpanato deleted the membershio-docs branch August 3, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haydentherapper haydentherapper haydentherapper left review comments

@lukehinds lukehinds lukehinds left review comments

@bobcallaway bobcallaway bobcallaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cpanato @dlorenc @lukehinds @naveensrinivasan @haydentherapper @bobcallaway @mrbobbytables