Migrate validator client to clap derive #6300
Conversation
eserilev
changed the title
validator_client/src/config.rs
Outdated
| if validator_client_config.web3_signer_keep_alive_timeout == 0 { | ||
| config.web3_signer_keep_alive_timeout = None | ||
| } else { | ||
| config.web3_signer_keep_alive_timeout = Some(Duration::from_millis( | ||
| validator_client_config.web3_signer_keep_alive_timeout, | ||
| )); |
There was a problem hiding this comment.
Note the breaking change here. Since I've defined web3_signer_keep_alive_timeout as a u64, null is no longer a valid option. Users will need to use 0 instead.
If this breaking change is too intrusive I can define web3_signer_keep_alive_timeout as a string and we can keep functionality as is.
There was a problem hiding this comment.
I think this is probably ok, not sure if anyone actually remove the web3signer timeout? (cc @michaelsproul)
I've added backwards-incompat label.
There was a problem hiding this comment.
Yeah this is probably obscure enough that we would be OK to change it. It's a bit dodgy because it flips the meaning of 0 from "timeout immediately" to "never timeout", but I doubt anyone is using 0
eserilev
added
work-in-progress
…ap-derive-validator-manager
…ap-derive-validator-manager
eserilev
added
ready-for-review
|
Maybe we should merge this PR first, as it will conflict: |
michaelsproul
added
waiting-on-author
|
Age's PR is merged now. Some conflicts to resolve and then we can merge this. |
…ap-derive-validator-manager
eserilev
added
ready-for-review
|
merge conflicts have been resolved |
…ap-derive-validator-manager
|
This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏 |
jimmygchen
added
ready-for-merge
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Issue Addressed
Partially #5900
Proposed Changes
Migrate the validator client cli to clap derive