Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segmentation fault in kws_connect_ex #148

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix segmentation fault in kws_connect_ex #148

merged 1 commit into from
Dec 20, 2024

Conversation

azzbcc
Copy link
Contributor

@azzbcc azzbcc commented May 23, 2023

Meet the same segfault like #62 .

@andywolk
Copy link
Contributor

Please test against latest master (v2.0.1) and resolve conflicts if the issue exists still.

@azzbcc azzbcc force-pushed the fix/at/family branch 3 times, most recently from 40606ce to 67daf31 Compare December 20, 2024 16:33
@azzbcc
Copy link
Contributor Author

azzbcc commented Dec 20, 2024

#211

gethostbyname() is not thread-safe on some platforms.

@andywolk andywolk added the bug Something isn't working label Dec 20, 2024
@andywolk andywolk changed the title Fix segmentation fault. Fix segmentation fault in kws_connect_ex Dec 20, 2024
@andywolk andywolk merged commit 6c94460 into signalwire:master Dec 20, 2024
17 checks passed
@andywolk
Copy link
Contributor

Thank you!

@azzbcc azzbcc deleted the fix/at/family branch December 20, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andywolk andywolk andywolk approved these changes

@Astaelan Astaelan Awaiting requested review from Astaelan

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azzbcc @andywolk