Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix collect-solr integration tests #5835

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

dmitryax
Copy link
Contributor

@dmitryax dmitryax commented Jan 24, 2025

Fixes failing tests https://github.com/signalfx/splunk-otel-collector/actions/runs/12961586015/job/36157162873?pr=5835

Ignore values of the following metrics:

  • gauge.solr.core_max_docs
  • gauge.solr.core_num_docs
  • counter.solr.update_handler_requests

They are just added to the list of pmetrictest.IgnoreMetricValues arguments. The list is also sorted.

@dmitryax dmitryax requested review from a team as code owners January 24, 2025 19:49
@dmitryax dmitryax marked this pull request as draft January 24, 2025 19:50
@dmitryax dmitryax force-pushed the trigger-package-tests branch from 803cc07 to 0b665a7 Compare January 25, 2025 03:51
Ignore values of the following metrics:
- gauge.solr.core_max_docs
- gauge.solr.core_num_docs
- counter.solr.update_handler_requests

They are just added to the list of pmetrictest.IgnoreMetricValues arguments. The list is also sorted
@dmitryax dmitryax force-pushed the trigger-package-tests branch from 0b665a7 to 506170a Compare January 25, 2025 05:45
@dmitryax dmitryax changed the title [draft] trigger package tests [chore] Fix collect-solr integration tests Jan 25, 2025
@dmitryax dmitryax marked this pull request as ready for review January 25, 2025 05:46
@dmitryax dmitryax merged commit fea62c9 into main Jan 27, 2025
74 checks passed
@dmitryax dmitryax deleted the trigger-package-tests branch January 27, 2025 18:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants