Modularized dialog creation library #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sieukrem
reviewed
Sep 6, 2020
|
|
||
| var CSSLintMenuCfg = { | ||
| text:"CSS Lint", | ||
| oninitpopup:function(){ | ||
| this.verifyMenuItem.disabled = !/\.css/i.test(currentView.files[currentView.file]); | ||
| this.verifyMenuItem.disabled = !/\.(css|php|html)/i.test(currentView.files[currentView.file]); |
There was a problem hiding this comment.
does the csslint work also on php and html files properly? Maybe it is worth to make it part of settings or control it via (un)check in the menu?
KOLANICH
commented
Dec 26, 2020
| }, | ||
| cell:function(r, arr){ | ||
| for(var i=0,c=arr.length; i<c; i++) | ||
| r.insertCell().innerHTML = arr[i]; |
There was a problem hiding this comment.
Oh SHIT, I dislike this code, it feels like a vulnr.
KOLANICH
commented
Dec 26, 2020
| function createDialog(cfg){ | ||
| var header = ""; | ||
| for(var i=0; i<cfg.header.length; i++) | ||
| header +="<th>"+cfg.header[i]+"</th>"; |
There was a problem hiding this comment.
and this one too. Should definitely try to improve this. But I don't remember currently why don't I use DOM API here and if it is possible at allmor not. In fact I have modularized that very long ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.